Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable GNU extensions for libc globally #1196

Merged
merged 1 commit into from Dec 9, 2016

Conversation

@sergeuz
Copy link
Member

commented Dec 4, 2016

This PR reverts some of the changes introduced by #1159 and re-enables GNU extensions for libc globally in build/module.mk file. If necessary, GNU extensions can be disabled for a particular module by defining NO_GNU_EXTENSIONS=1 variable in a module's makefile.

Primary motivation for this patch is to ensure that existent user applications that depend on GNU extensions will continue to be compiled normally. We also have discovered a regression in the newlib header files bundled with ARM GCC 4.9.3 Q1 specifically, which doesn't allow _POSIX_C_SOURCE to be overridden by _GNU_SOURCE in selected source files.

Tested with GCC 5.4.1, 5.3.1 and 4.9.3 (Q1).


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Internal

  • Re-enable GNU extensions for libc globally. Fixes build with ARM GCC 4.9.3 Q1.

@sergeuz sergeuz added this to the 0.6.1 milestone Dec 4, 2016

@technobly technobly merged commit f475f5b into develop Dec 9, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/gcc_5_4_x branch Dec 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.