Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Windows, Mac Command, & *nix Meta Keys #1217

Merged
merged 2 commits into from Jan 11, 2017

Conversation

@harrisonhjones
Copy link
Contributor

commented Dec 25, 2016

Added:

  • Windows left & right key reference
  • Mac command left & right key reference
  • *nix meta left & right key reference

Problem: Platform-specific command keys not called out in scancode reference. Addition prompted by confusion in the forums.

Solution: Add platform-specific command keys to scancode reference.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Enhancements

  • [PR# 1217] Added Windows, Mac command, & Unix/Linux meta USB keyboard scancode definitions.
Added Windows, Mac Command, & *nix Meta Keys
Added:
 - Windows left & right key reference
 - Mac command left & right key reference
 - *nix meta left & right key reference
@avtolstoy

This comment has been minimized.

Copy link
Member

commented Dec 25, 2016

LGUI/RGUI modifiers should probably also be aliased then:
https://github.com/spark/firmware/blob/develop/wiring/inc/spark_wiring_usbkeyboard_scancode.h#L401

// Right now in order to click Win-x you would still have to use MOD_LGUI
Keyboard.click(KEY_X, MOD_LGUI);
@harrisonhjones

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2016

Added the aliases for the modifier keys as well. Thoughts @avtolstoy ?

@technobly technobly requested a review from avtolstoy Dec 28, 2016

@harrisonhjones

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2016

What are next steps on this? I'm not sure where I am supposed to add documentation and I'm unsure who will pull this code in and when. Thanks for the help

@technobly

This comment has been minimized.

Copy link
Member

commented Dec 28, 2016

@harrisonhjones these changes will be merged into develop soon to create a 0.6.1-rc.2 firmware revision.

It's kind of self documented here: https://docs.particle.io/reference/firmware/photon/#click--1 so I don't think any extra documentation is required. Thanks for the PR!

@technobly technobly added this to the 0.6.1 milestone Dec 28, 2016

@technobly technobly merged commit 13ce5bd into particle-iot:develop Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.