Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding logging here without { } was publishing safe mode unconditionally #1230

Merged
merged 1 commit into from Jan 13, 2017

Conversation

@technobly
Copy link
Member

commented Jan 10, 2017

Adding logging here without { } was publishing safe mode unconditionally


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device (N/A)
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfixes

  • [PR #1230] Safe Mode event was being published unconditionally

@technobly technobly added the bug label Jan 10, 2017

@technobly technobly added this to the 0.6.1 milestone Jan 10, 2017

@technobly technobly requested a review from avtolstoy Jan 10, 2017

@technobly technobly merged commit 767e94e into develop Jan 13, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/fix-safe-mode branch Jan 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.