Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Fixes double newline parser issue on G350 introduced in 428835a #1231

Merged
merged 2 commits into from Jan 18, 2017

Conversation

@technobly
Copy link
Member

commented Jan 18, 2017

Fixes double newline parser issue on G350 introduced in 428835a

This resolves a case on G350 where \r\n is generated after +USORF response, but missing
on U260/U270, which would otherwise generate \r\n\r\nOK\r\n which is not parseable. This was preventing the G350 from handshaking with the Cloud on v0.6.1-rc.1.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bug fixes

  • [PR #1231] [Electron] fixes double newline parser issue on G350 introduced in 428835a 0.6.1-rc.1

@technobly technobly added the bug label Jan 18, 2017

@technobly technobly added this to the 0.6.1 milestone Jan 18, 2017

@technobly technobly requested a review from avtolstoy Jan 18, 2017

@technobly technobly merged commit 93be3ca into develop Jan 18, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/double-crlf-fix branch Jan 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.