Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle.publish() flags fixes #1236

Merged
merged 1 commit into from Mar 14, 2017

Conversation

@sergeuz
Copy link
Member

commented Jan 20, 2017

This PR sanitizes Particle.publish() overloads, making it possible to specify one or two flags for any variant of this method. The PR also implements a generic type-safe wrapper for enum-based flags, aka particle::Flags<T>, which enables regular syntax for ORed flag combinations as an option:

Particle.publish("event", "data", PRIVATE | NO_ACK);

Fixes #1201 and #1194.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bug fixes

Enhancements

@sergeuz sergeuz added this to the 0.7.0 milestone Jan 20, 2017

@technobly technobly merged commit 7bf2aa8 into develop Mar 14, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/publish_flags branch Mar 14, 2017

@sergeuz sergeuz referenced this pull request Apr 27, 2017
6 of 6 tasks complete
@avtolstoy avtolstoy referenced this pull request Jul 7, 2017
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.