Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB LED fixes [ch1742] #1237

Merged
merged 6 commits into from Mar 15, 2017

Conversation

@sergeuz
Copy link
Member

commented Jan 22, 2017

This PR introduces the following changes:

  • Fixes potential memory leak and race condition issues in RGB.onChange() method.
  • Fixes unit/led_service.cpp and wiring/no_fixture/led.cpp tests that are currently failing intermittently (CH story 1742).
  • Raises priority of the listening mode LED indication in single-threaded mode.

TODO: Update firmware reference

uint8 value = RGB.brightness(); // getter function


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (uint8 value = RGB.brightness(); // getter function)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bug fixes

  • [PR #1237] Fixes potential memory leak and race condition issues in RGB.onChange() function.

@sergeuz sergeuz added this to the 0.7.0 milestone Jan 22, 2017

@technobly technobly changed the title RGB LED fixes RGB LED fixes [ch1742] Feb 9, 2017

@technobly technobly added the bug label Feb 9, 2017

@technobly technobly merged commit 656851a into develop Mar 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/led_tests branch Mar 15, 2017

@sergeuz sergeuz referenced this pull request Jul 9, 2017
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.