Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event data corruption in multithreaded firmware #1246

Merged
merged 1 commit into from Feb 4, 2017

Conversation

@sergeuz
Copy link
Member

commented Feb 4, 2017

This PR fixes possible corruption of an event data in multithreaded firmware. Symptoms of the problem are described here: http://community.particle.io/t/webhooks-corrupt-data-in-multipart-webhook-response/28683


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device (N/A)
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bug fixes

  • [PR #1246] Fixes possible corruption of event data in multi-threaded firmware
Fix an oversight in parameters forwarding that may cause corruption o…
…f event data when threading is enabled

@sergeuz sergeuz added the bug label Feb 4, 2017

@sergeuz sergeuz added this to the 0.7.0 milestone Feb 4, 2017

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2017

So glad to see this fix! I knew I had designed for it to work in principle, but clearly a typo meant that the design wasn't reflected in reality.

@m-mcgowan
Copy link
Contributor

left a comment

great catch!

@sergeuz

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2017

Yep, it was unlikely for this problem to have any other origin, since the protocol code is synchronous internally. Would you mind merging this PR?

@m-mcgowan m-mcgowan merged commit 0dd5010 into develop Feb 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/event_data branch Feb 9, 2017

@technobly technobly added the confirmed label Mar 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.