Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 'using std::**' instead of define * std::* #1258

Merged
merged 1 commit into from Jan 15, 2018

Conversation

@kreopt
Copy link
Contributor

commented Feb 22, 2017

Summary of Commits:
Fix C++ build using std::isnan or std::isinf with explicit namespace specification

Problem:
Using define for using c++ namespaces breaking compilation when names are used with explicit namespace specification. So std::isnan converts to std::std::isnan.

Solution:
use c++ using keyword insead of define.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
@sergeuz

This comment has been minimized.

Copy link
Member

commented May 10, 2017

@m-mcgowan Mat, could you review this? I remember you were working on something related to math.h and Arduino compatibility.

@m-mcgowan m-mcgowan self-requested a review Jan 15, 2018

@m-mcgowan m-mcgowan merged commit da387c0 into particle-iot:develop Jan 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m-mcgowan m-mcgowan added this to the 0.8.0-rc.2 milestone Jan 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.