Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make System.sleep(mode, seconds) a synchronous operation #1259

Merged
merged 1 commit into from May 4, 2017

Conversation

@sergeuz
Copy link
Member

commented Feb 23, 2017

This PR fixes #1176 by making System.sleep(mode, seconds) a synchronous operation in multithreaded firmware. This allows to ensure that the device is in a well-defined state before entering sleep mode.


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfix

  • [PR #1259] [Fixes #1176] Makes System.sleep(mode, seconds) a synchronous operation in multithreaded firmware. This ensures the device is in a well-defined state before entering sleep mode.
Make System.sleep(mode, seconds) a synchronous operation to ensure th…
…at the device is in a well-defined state before entering sleep mode

@sergeuz sergeuz added the bug label Feb 23, 2017

@sergeuz sergeuz added this to the 0.7.0 milestone Feb 23, 2017

@technobly technobly merged commit 8b0e660 into develop May 4, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/sync_sleep branch May 4, 2017

@avtolstoy avtolstoy referenced this pull request Jan 18, 2018
3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.