Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Wire1 fixes #1302

Merged
merged 7 commits into from May 9, 2017

Conversation

@avtolstoy
Copy link
Member

commented Apr 18, 2017

Problem

Issue #1282.

  • Wire1 on Electron does not work correctly.
  • There are no Wire1 I2C tests

Solution

  • Ensures that Wire and Wire1 on Electron cannot be enabled simultaneously, since they share the same peripheral
  • wiring/no_fixture test added: WIRE_02_Wire_and_Wire1_cannot_be_enabled_simultaneously_on_Electron
  • Correct HAL I2C interface id needs to passed when I2C1 interrupt handler is executed, depending on whether Wire or Wire1 is enabled.
  • Wire::reset() implementation moved to HAL (HAL_I2C_Reset)
  • i2c_master_slave and i2c_mcp23017 tests now accept USE_WIRE make argument that specifies which Wire interface should be used in tests (e.g. make PLATFORM=electron TEST=wiring/i2c_mcp23017 USE_WIRE=Wire1 clean all program-dfu)

Steps to Test

  • wiring/no_fixture: WIRE_02_Wire_and_Wire1_cannot_be_enabled_simultaneously_on_Electron
  • i2c_mcp23017
  • i2c_master_slave/i2c_master and i2c_master_slave/i2c_slave

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Bugfix

@technobly technobly added this to the 0.7.0 milestone May 4, 2017

@technobly technobly added the bug label May 9, 2017

@technobly technobly merged commit e1a519b into develop May 9, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/electron/i2c-wire1-fixes branch May 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.