Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Photon] Fixes WiFi.scan() hardfault #1354

Merged
merged 2 commits into from Jul 10, 2017

Conversation

@avtolstoy
Copy link
Member

commented Jul 10, 2017

Problem

A call to WiFi.scan() when WiFi module is off or not ready results in a hard fault.

See #1062

Solution

Photon wlan_hal: sniff_security() should check that wiced_wlan_connectivity_initialized() returns true

Steps to Test

  • wiring/no_fixture: WIFI_11_scan_returns_zero_result_or_error_when_wifi_is_off

Example App

N/A

References

Closes #1062


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (If not already documented, should explain to user this function won't work properly when Wi-Fi is off or !ready.)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Bug fix

  • [PR #1354] [Fixes #1062] A call to WiFi.scan() when Wi-Fi module is off or not ready was resulting in a hard fault.
avtolstoy added 2 commits Jun 27, 2017
wiring/no_fixture: Added WIFI_11_scan_returns_zero_result_or_error_wh…
…en_wifi_is_off and WIFI_12_restore_connection tests

@technobly technobly added the bug label Jul 10, 2017

@technobly technobly added this to the 0.7.0 milestone Jul 10, 2017

@technobly technobly merged commit 51400d4 into develop Jul 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/wlan-scan-hardfault branch Jul 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.