Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ch3737 6 digit serial [0.7.0-rc.2] #1357

Merged
merged 5 commits into from Jul 12, 2017

Conversation

@m-mcgowan
Copy link
Contributor

commented Jul 11, 2017

Problem

Device setup codes should be 6 digits to reduce the likelihood of collisions.

Solution

Expands the device code from 4 digits to 6 digits for Photon/P1/Electron platforms.

Steps to Test

See #1353
USER_PART_MODULE_VERSION should be bumped

Reference

Fixes #1348


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Enhancement

  • [PR #1357] Expands the device code from 4 digits to 6 digits for Photon/P1/Electron platforms

Bug fix

  • [PR #1357] [Fixes #1348] SoftAP SSID was not respecting the string's null terminator, 2 char SSID would appear as 4.
m-mcgowan added 4 commits Jul 10, 2017
factors the device code generation from the Photon HAL into a common …
…stm32 area so it can be used on the Electron too. Changes maximum length of the device code to 6 chars. Device code retrieval tweaked to allow the device code to be less than the maximum length of 6 chars.
fixes #1348 - ensures the null terminator is also copied if the strin…
…g is less than the maximum field width.

@m-mcgowan m-mcgowan added this to the 0.7.0 milestone Jul 11, 2017

@technobly technobly added the bug label Jul 12, 2017

@technobly technobly merged commit deb48b2 into develop Jul 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/ch3737-6-digit-serial branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.