Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes build with PLATFORM=gcc on OSX with clang's gcc wrapper #1359

Merged
merged 1 commit into from Jul 12, 2017

Conversation

@avtolstoy
Copy link
Member

commented Jul 12, 2017

Problem

PLATFORM=gcc builds fail on OSX with default gcc compiler (which is actually a wrapper over clang).

Solution

  • Provide some clang-specific fixes

Steps to Test

  • make PLATFORM=gcc clean all should succeed with OSX gcc:
$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin14.5.0
Thread model: posix

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (N/A)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Internal

  • [PR #1359] Fixes build with PLATFORM=gcc on OSX with clang's gcc wrapper

@technobly technobly added this to the 0.7.0 milestone Jul 12, 2017

@technobly technobly added the internal label Jul 12, 2017

@technobly technobly merged commit c5e9492 into develop Jul 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/osx-platform-gcc-build branch Jul 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.