Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Diagnostics] Datasources: number of unacknowledged messages, number of rate limited events #1391

Closed

Conversation

@avtolstoy
Copy link
Member

commented Sep 19, 2017

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Solution

Implements:

  • Datasource for the number of unacknowledged CoAP messages (DIAG_ID_CLOUD_UNACKNOWLEDGED_MESSAGES)
  • Datasource for the number of events dropped due to rate limiting (DIAG_ID_CLOUD_RATE_LIMITED_EVENTS)

Steps to Test

N/A

Example App

N/A

References

  • [CH7640]
  • [CH7641]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@m-mcgowan m-mcgowan self-requested a review Sep 26, 2017

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Sep 26, 2017

Good changes 👍 , please fix up the conflict so we can merge

@avtolstoy avtolstoy force-pushed the feature/diagnostics-cloud-ratelimit-unack branch from e9eaeac to 13efa08 Sep 26, 2017

Specifies DIAG_ID_CLOUD_RATE_LIMITED_EVENTS and DIAG_ID_CLOUD_UNACKNO…
…WLEDGED_MESSAGES string names in-place during construction

@m-mcgowan m-mcgowan added this to the 0.8.0 milestone Nov 14, 2017

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

this has been merged into develop

@m-mcgowan m-mcgowan closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.