Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Diagnostics] Batterry state diagnostic datasource #1398

Conversation

Projects
None yet
3 participants
@avtolstoy
Copy link
Member

commented Sep 26, 2017

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Solution

Implements battery state of charge diagnostic data source (DIAG_ID_SYSTEM_BATTERY_STATE):

    BATTERY_STATE_UNKNOWN = 0,
    BATTERY_STATE_NOT_CHARGING = 1,
    BATTERY_STATE_CHARGING = 2,
    BATTERY_STATE_CHARGED = 3,
    BATTERY_STATE_DISCHARGING = 4,
    BATTERY_STATE_FAULT = 5

Steps to Test

N/A

Example App

N/A

References

  • [CH7639]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy changed the base branch from develop to feature/diagnostics-battery-charge Sep 26, 2017

@avtolstoy avtolstoy changed the title [Diagnostics] Batterry state diagnostic [Diagnostics] Batterry state diagnostic datasource Sep 26, 2017

@m-mcgowan m-mcgowan requested a review from technobly Oct 3, 2017

@avtolstoy avtolstoy referenced this pull request Oct 23, 2017

Merged

[Electron] Power management #1412

3 of 6 tasks complete

@m-mcgowan m-mcgowan added this to the 0.8.0 milestone Oct 31, 2017

@technobly
Copy link
Member

left a comment

please see comments in #1412

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented Nov 6, 2017

superceded by #1412

@m-mcgowan m-mcgowan closed this Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.