Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB request handlers #1444

Merged
merged 59 commits into from Jan 19, 2018

Conversation

@avtolstoy
Copy link
Member

commented Dec 7, 2017

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Solution

This is a merge of #1440 and #1441 branches with some minor refactoring.

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)
sergeuz and others added 30 commits Sep 4, 2017
avtolstoy and others added 9 commits Dec 1, 2017
Merge remote-tracking branch 'origin/feature/wifi-network-ctrl-req' i…
…nto feature/nanopb

Conflicts:
        system/inc/system_control.h
	system/src/control/build.sh
	system/src/control/common.pb.c
	system/src/control/common.pb.h
	system/src/control/common.proto
	system/src/system_control_internal.cpp

Proto files rebuilt:
       modified:   ../system/src/control/common.pb.c
       modified:   ../system/src/control/common.pb.h
       modified:   ../system/src/control/config.pb.c
       modified:   ../system/src/control/config.pb.h
       modified:   ../system/src/control/control.pb.c
       modified:   ../system/src/control/control.pb.h
       new file:   ../system/src/control/network.pb.c
       new file:   ../system/src/control/network.pb.h
       new file:   ../system/src/control/wifi.pb.c
       new file:   ../system/src/control/wifi.pb.h
@avtolstoy avtolstoy referenced this pull request Dec 21, 2017
3 of 6 tasks complete
@sergeuz sergeuz referenced this pull request Dec 21, 2017
3 of 6 tasks complete

@sergeuz sergeuz added this to the 0.8.0 milestone Jan 16, 2018

@m-mcgowan m-mcgowan modified the milestones: 0.8.0, 0.8.0-rc.2 Jan 18, 2018

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented on services/src/nanopb_misc.c in 37ca30a Jan 19, 2018

why not assignment?

This comment has been minimized.

Copy link
Member Author

replied Jan 19, 2018

¯_(ツ)_/¯ Why, indeed?

@m-mcgowan

This comment has been minimized.

Copy link
Contributor

commented on system/src/system_control_internal.cpp in 3bafa4d Jan 19, 2018

can we make these the same values and hopefully the compiler will notice the mapping is identity and optimize it out?

@m-mcgowan m-mcgowan self-requested a review Jan 19, 2018

@avtolstoy avtolstoy merged commit 444f575 into develop Jan 19, 2018

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@m-mcgowan m-mcgowan added the feature label Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.