Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usage of an incorrect prerequisite name in program-* targets #1463

Merged
merged 1 commit into from Jan 18, 2018

Conversation

@sergeuz
Copy link
Member

commented Jan 17, 2018

Problem

This PR fixes an issue introduced by 9aa4b8f, which causes GNU make to fail when invoked with such targets as program-dfu, program-ocd, etc.

Steps to Test

Check that the make -s all TARGET command work as expected with program-dfu, program-ocd, st-flash, program-cloud, program-serial targets.

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added the bug label Jan 17, 2018

@sergeuz sergeuz added this to the 0.8.0 milestone Jan 17, 2018

@sergeuz sergeuz requested a review from m-mcgowan Jan 17, 2018

@m-mcgowan
Copy link
Contributor

left a comment

nice job!

@m-mcgowan m-mcgowan modified the milestones: 0.8.0, 0.8.0-rc.2 Jan 18, 2018

@m-mcgowan m-mcgowan merged commit 4ba9076 into develop Jan 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.