Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash size optimizations #1469

Merged
merged 3 commits into from Jan 20, 2018

Conversation

@avtolstoy
Copy link
Member

commented Jan 19, 2018

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Problem

Some things can be moved out of Electron system-part2 (module index 1) and system-part3 (module index 2) to free up flash space there.

Solution

  • Move nanopb into its own static lib
  • [Electron] Move nanopb from services to services2 residing in system-part1 (module index 3)
  • [Electron] Move _printf_float into services2
  • TODO: [Electron] Move other printf/scanf functions into services2

Steps to Test

N/A

Example App

N/A

References

  • [CH10790]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)
Moves nanopb to separate static lib. Juggles some things around betwe…
…en modules to free some space in Electron system-part3

@avtolstoy avtolstoy added this to the 0.8.0-rc.2 milestone Jan 19, 2018

@avtolstoy avtolstoy requested a review from m-mcgowan Jan 19, 2018

@avtolstoy avtolstoy referenced this pull request Jan 19, 2018
3 of 6 tasks complete
avtolstoy added 2 commits Jan 19, 2018
@m-mcgowan
Copy link
Contributor

left a comment

Bravo. For safety's sake, could you please check there are no_wiring tests for the functions that were moved.

@m-mcgowan m-mcgowan merged commit 3d49329 into develop Jan 20, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the feature/080rc2-size-optimizations branch Jan 20, 2018

@avtolstoy avtolstoy referenced this pull request Jan 22, 2018
3 of 6 tasks complete
@sergeuz sergeuz referenced this pull request Jan 22, 2018
3 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.