Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron: moves some newlib functions into part1 #1471

Merged
merged 1 commit into from Jan 22, 2018

Conversation

@avtolstoy
Copy link
Member

commented Jan 22, 2018

Problem

Some things can be moved out of Electron system-part3 (module index 2) to free up flash space there. See also #1469.

Solution

  • Export _tzset_unlocked_r, __udivmoddi4, mktime, __ssvfscanf_r, _printf_i, localtime_r

Results

This branch

   text	   data	    bss	    dec	    hex	filename
  72932	    556	   2588	  76076	  1292c	../../../build/target/system-part1/platform-10-m/system-part1.elf
   text	   data	    bss	    dec	    hex	filename
 117932	    216	    564	 118712	  1cfb8	../../../build/target/system-part2/platform-10-m/system-part2.elf
   text	   data	    bss	    dec	    hex	filename
 115404	   2700	   3988	 122092	  1dcec	../../../build/target/system-part3/platform-10-m/system-part3.elf
   text	   data	    bss	    dec	    hex	filename
   3708	    108	   1468	   5284	   14a4	../../../build/target/user-part/platform-10-m/blank.elf

develop

   text	   data	    bss	    dec	    hex	filename
  66308	    480	   2548	  69336	  10ed8	../../../build/target/system-part1/platform-10-m/system-part1.elf
   text	   data	    bss	    dec	    hex	filename
 118676	    216	    564	 119456	  1d2a0	../../../build/target/system-part2/platform-10-m/system-part2.elf
   text	   data	    bss	    dec	    hex	filename
 122500	   2776	   4028	 129304	  1f918	../../../build/target/system-part3/platform-10-m/system-part3.elf
   text	   data	    bss	    dec	    hex	filename
   3708	    108	   1468	   5284	   14a4	../../../build/target/user-part/platform-10-m/blank.elf

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 0.8.0-rc.2 milestone Jan 22, 2018

@avtolstoy avtolstoy requested a review from m-mcgowan Jan 22, 2018

@m-mcgowan m-mcgowan merged commit 057a868 into develop Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the feature/electron-size-optimizations2 branch Jan 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.