Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS_CLAIMED request fixes #1472

Merged
merged 2 commits into from Jan 22, 2018

Conversation

@sergeuz
Copy link
Member

commented Jan 22, 2018

Problem

This PR introduces the following changes:

  • Rework IS_CLAIMED request to follow the pattern where a getter request carrying application-specific data should always have a reply message defined. See discussion here: #1440
  • Fix path to nanopb in system/src/control/proto/build.sh (the library has been moved to another directory in #1469).

Steps to Test

Using particle-usb library:

import * as usb from 'particle-usb';

async function test() {
  const dev = await usb.openDeviceById('...'); // FIXME
  const claimed = await dev.isClaimed();
  console.log(claimed);
}

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added this to the 0.8.0-rc.2 milestone Jan 22, 2018

@sergeuz sergeuz requested a review from m-mcgowan Jan 22, 2018

@m-mcgowan m-mcgowan merged commit 18e9115 into develop Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the fix/is_claimed_req branch Jan 22, 2018

@m-mcgowan m-mcgowan added the internal label Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.