Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of the USB protocol implementation #1473

Merged
merged 1 commit into from Jan 23, 2018

Conversation

@sergeuz
Copy link
Member

commented Jan 22, 2018

Problem

This PR splits implementation of UsbControlRequestChannel::processServiceRequest() into several methods, and adds comments to clarify which methods are called in the context of an ISR. See the discussion here: #1406

Steps to Test

  • user/tests/unit
  • user/tests/app/usb_ctrl_request

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added this to the 0.8.0 milestone Jan 22, 2018

@sergeuz sergeuz requested a review from m-mcgowan Jan 22, 2018

@m-mcgowan m-mcgowan modified the milestones: 0.8.0, 0.8.0-rc.2 Jan 23, 2018

@m-mcgowan m-mcgowan merged commit b805a88 into develop Jan 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the fix/usb_minor_fixes branch Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.