Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documents low level USB request completion notifications #1475

Merged
merged 1 commit into from Jan 24, 2018

Conversation

@avtolstoy
Copy link
Member

commented Jan 23, 2018

Solution

Documents low level USB request completion notifications as suggested in #1406. Replaces literal 1 with USB_REQ_DATA_STAGE_COMPLETED for better readability.

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)
Adds comments for low level USB request completion notifications; `1`…
… replaced with `USB_REQ_DATA_STAGE_COMPLETED` macro

@avtolstoy avtolstoy added this to the 0.8.0-rc.2 milestone Jan 23, 2018

@avtolstoy avtolstoy requested a review from m-mcgowan Jan 23, 2018

@m-mcgowan
Copy link
Contributor

left a comment

Thanks!

@m-mcgowan m-mcgowan merged commit f090c9c into develop Jan 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.