Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some 0.8.0-rc.2 tests #1476

Merged
merged 3 commits into from Jan 24, 2018

Conversation

@avtolstoy
Copy link
Member

commented Jan 23, 2018

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Problem

  1. Cellular band select tests should be performed while deregistered from the network, otherwise current RAT affects a selection of bands available. See 7.22 Select band +UBANDSEL documentation from u-blox Cellular Modules - AT Commands Manual:
TOBY-L2 / MPCI-L2 / LARA-R2 / TOBY-R2 / SARA-U2 / LISA-U2 / LISA-U1
The list of supported bands presents exclusively GSM, UMTS or LTE bands depending on which RAT the
MT is currently registered. If it is not registered, the bands presented depend on +URAT command:
• If in single mode, depends on <AcT>
• If in dual mode, depends on <PreferredAct>
  1. CONCURRENT_02_crc32_is_thread_safe causes a hardfault due to os_thread_join() not working on Electron.
  2. #1297 broke system power management and diagnostics by introducing a requirement to call previously non-existent begin() method. This change will break user applications as well.

Solution

  1. Perform AT+COPS=2 before executing band select tests
  2. Implement os_thread_join() for Electron
  3. Remove the requirement to call FuelGauge::begin() and add a constructor overload that takes a TwoWire instead of begin() method.

Steps to Test

  • wiring/no_fixture

Example App

N/A

References

  • [CH10790]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added this to the 0.8.0-rc.2 milestone Jan 23, 2018

@avtolstoy avtolstoy requested review from m-mcgowan and sergeuz Jan 23, 2018

FuelGauge: removes requirement to call begin(). Custom Wire interface…
… instead should be passed in constructor

@m-mcgowan m-mcgowan merged commit e0a4b63 into develop Jan 24, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan added the internal label Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.