Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds UPSV handling to cellular_hal #1480

Merged
merged 1 commit into from Feb 5, 2018

Conversation

Projects
None yet
2 participants
@technobly
Copy link
Member

commented Jan 25, 2018

Problem

No way to change the UPSV level so it doesn't get overridden when system firmware re-initializes the modem.

Solution

Adds a cellular_hal function to set the UPSV level from 0-3 (default: 1).

Steps to Test

  • Run test app, look for UPSV=0 in logs.
  • Comment out cellular_set_power_mode() and look for UPSV=1 in logs.

Example App

SYSTEM_MODE(SEMI_AUTOMATIC);
SerialLogHandler logHandler(LOG_LEVEL_ALL);

void setup() {
  cellular_set_power_mode(0, NULL);
  Particle.connect();
}

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • [N/A] Run unit/integration/application tests on device
  • [N/A] Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added this to the 0.8.0-rc.2 milestone Jan 25, 2018

@technobly technobly requested a review from m-mcgowan Jan 25, 2018

@m-mcgowan m-mcgowan merged commit f434248 into develop Feb 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/upsv-handling branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.