Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Adds `keepalive_source_t` to infer when Pinger interval should be updated #1536

Merged
merged 2 commits into from May 3, 2018

Conversation

Projects
None yet
2 participants
@technobly
Copy link
Member

commented May 3, 2018

Problem

Particle.keepAlive() API was broken since v0.6.2-rc.2 firmware on Electron where the System could override a User set ping interval. This required a workaround of updating the keepAlive after the System made a connection to the Cloud. See issue #1482.

Solution

Adds keepalive_source_t to infer when Pinger interval should be updated. The only time the interval will not be updated is when the User has previously set it, and the System tries to override it. All other cases are updatable.

Steps to Test

communication unit tests added and ran by merging this PR with branch feature/ch13052 then run firmware/communication/tests/catch $ make all run

Also the test app found in issue #1482 now works as expected without the workaround.

Referencecs

fixes #1482

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • [N/A] Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added the bug label May 3, 2018

@technobly technobly added this to the 0.8.0-rc.4 milestone May 3, 2018

@technobly technobly requested a review from m-mcgowan May 3, 2018

@technobly technobly merged commit 3dc9060 into develop May 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/keepalive branch May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.