Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Fixes monolithic build #1543

Merged
merged 1 commit into from Jun 1, 2018

Conversation

@technobly
Copy link
Member

commented May 31, 2018

Problem

firmware/main$ make clean all -s PLATFORM=electron MODULAR=n was failing

Solution

Adds a few missing headers

Steps to Test

Should build without errors firmware/main$ make clean all -s PLATFORM=electron MODULAR=n


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (N/A)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added the internal label May 31, 2018

@technobly technobly added this to the 0.8.0-rc.6 milestone May 31, 2018

@technobly technobly requested a review from sergeuz May 31, 2018

@technobly technobly merged commit b0a2a69 into develop Jun 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/electron-monolithic-build branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.