Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] fixes sticker-rig issue with POWER_ON command #1544

Merged
merged 2 commits into from Jun 1, 2018

Conversation

@technobly
Copy link
Member

commented May 31, 2018

Problem

POWER_ON:; was operating intermittently in the Sticker Rig during MFG'ing for LTE E-Series modules.

Solution

delay(200) used in the test routine was changed to HAL_Delay_Milliseconds(200) to avoid the situation where the spark_process() is run after an accumulation of 1s. This was causing the device to try to re-connect to the cloud while it was in listening mode, and AT commands were getting interrupted.

Steps to Test

Run firmware/user/tests/accept/sticker-rig test several times to verify it completes successfully.

E.g. with Python 2.7.14 installed, running:

python test.py /dev/cu.usbserial-A702OGCQ /dev/cu.usbmodem141441

Test will complete without failure each time:

Tests PASSED!!


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation (N/A)
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added the internal label May 31, 2018

@technobly technobly added this to the 0.8.0-rc.6 milestone May 31, 2018

@technobly technobly requested a review from m-mcgowan May 31, 2018

@m-mcgowan
Copy link
Contributor

left a comment

I didn't test - the code change looks harmless, and makes sense from the description.

@technobly technobly merged commit 7822d83 into develop Jun 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/sticker-rig-issue branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.