Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LTE/Electron] eDRX & Power Saving mode disabled by default #1567

Merged
merged 3 commits into from Aug 18, 2018

Conversation

@technobly
Copy link
Member

commented Aug 17, 2018

Problem

eDRX is enabled by default on production u-Blox modules, and it causes a variable lag in the network data transmissions that we do not account for at this time.

Solution

  1. Force eDRX to be disabled

  2. Force Power Saving mode to be disabled (for good measure)

  3. This PR also adds some logs for 2G/3G devices that query the modem for the DNS servers used. Right now there are no high level APIs implemented, but later we can add support for Cellular.dnsServerIP() like was done for WiFi devices: https://docs.particle.io/reference/firmware/photon/#dnsserverip-

  4. This PR also increases the OTA update timeout on Electron/LTE devices to 300 seconds (up from 90). This allows LTE devices on the lossier Cat-M1 network to have a better chance of receiving resent UpdateDone messages.

Steps to Test

Manual testing required:

  1. Flash LTE device with this system firmware and tinker
  2. Make a function call particle call <device> digitalwrite D7,LOW
  3. It should return 1 if successful
  4. Wait 3 minutes
  5. Make a function call particle call <device> digitalwrite D7,LOW
  6. It should return 1 if successful

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • [n/a] Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added the bug label Aug 17, 2018

@technobly technobly added this to the 0.8.0-rc.10 milestone Aug 17, 2018

@technobly technobly requested a review from m-mcgowan Aug 17, 2018

@jtzemp
jtzemp approved these changes Aug 18, 2018
Copy link

left a comment

LGTM! 👍

@technobly technobly merged commit 936df3c into develop Aug 18, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/edrx-psm-disabled-by-default branch Aug 18, 2018

@technobly technobly referenced this pull request May 3, 2019
5 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.