New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an assertion failure in LwIP DHCP code when receiving an offer with > 2 DNS servers #1618

Merged
merged 2 commits into from Dec 3, 2018

Conversation

Projects
None yet
2 participants
@avtolstoy
Copy link
Member

avtolstoy commented Dec 3, 2018

Problem

Xenons with Ethernet FeatherWing and Argons go into panic state due to an assertion failure in LwIP DHCP code when receiving a DHCP OFFER with more than 2 DNS servers.

Solution

  1. Fix the bug in LwIP code: particle-iot/lwip#4
  2. Disables LwIP assertions in non-debug builds

Steps to Test

Configure DHCP server to provide more than 2 DNS servers. The devices should successfully lease an IP address without going into panic.

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added bug mesh labels Dec 3, 2018

@avtolstoy avtolstoy requested a review from sergeuz Dec 3, 2018

@sergeuz

sergeuz approved these changes Dec 3, 2018

@avtolstoy avtolstoy merged commit 771471a into mesh-develop Dec 3, 2018

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@avtolstoy avtolstoy deleted the fix/lwip-dhcp-max-servers branch Dec 3, 2018

avtolstoy added a commit that referenced this pull request Dec 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment