Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache persistent feature flags #1640

Merged
merged 1 commit into from Dec 14, 2018

Conversation

@sergeuz
Copy link
Member

commented Dec 14, 2018

Problem

DCT operations in WICED 3.7.0 consume significantly more stack memory than in WICED 3.3.0. This may cause a stack overflow in HAL_Core_System_Reset(), which checks whether the reset info feature flag is set in the DCT.

Solution

Cache persistent feature flags in RAM.

Steps to Test

The application provided in the original issue should work correctly without changing the default stack size of the watchdog thread.

References

  • [ch26433]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz requested a review from m-mcgowan Dec 14, 2018

@sergeuz sergeuz added ready to merge and removed needs review labels Dec 14, 2018

@sergeuz sergeuz merged commit f9bbf94 into develop Dec 14, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sergeuz sergeuz deleted the fix/cache_feature_flags branch Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.