Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mesh som #1662

Merged
merged 8 commits into from Mar 5, 2019

Conversation

@XuGuohui
Copy link
Contributor

commented Dec 28, 2018

  • [Mesh] Adds Argon SoM, Boron SoM and Xenon SoM platforms to Device OS #1662

@XuGuohui XuGuohui requested a review from avtolstoy Dec 28, 2018

@XuGuohui XuGuohui force-pushed the feature/mesh_som branch from 3ff50f8 to 0566da8 Dec 30, 2018

@XuGuohui XuGuohui added needs review and removed in progress labels Dec 30, 2018

en2 = new WizNetif(HAL_SPI_INTERFACE1, D5, D3, D4, mac);
#else // Argon SoM
en2 = new WizNetif(HAL_SPI_INTERFACE1, D8, 0xFF, D22, mac);

This comment has been minimized.

Copy link
@avtolstoy

avtolstoy Jan 16, 2019

Member

We are setting RESET pin to PIN_INVALID here for some reason. Did we want to have CS pin to be set to the default instead?

WizNetif(HAL_SPI_Interface spi, pin_t cs, pin_t reset, pin_t interrupt, const uint8_t mac[6]);

This comment has been minimized.

Copy link
@XuGuohui

XuGuohui Jan 24, 2019

Author Contributor

We are going to connect A7 to the Ethernet reset pin on the final mesh EVB. Will change it here in advance. It's not very meaningful to set the cs pin to a default, cos D5 is not the default CS pin for mesh dev kits. Also for future platforms, it might not use the default CS pin for the Ethernet.

en2 = new WizNetif(HAL_SPI_INTERFACE1, D5, D3, D4, mac);
#else // Boron SoM
en2 = new WizNetif(HAL_SPI_INTERFACE1, D8, 0xFF, D22, mac);

This comment has been minimized.

Copy link
@avtolstoy

avtolstoy Jan 16, 2019

Member

Same here.



led_config_t HAL_Leds[] = {
{
.version = 0x00,
.pin = LED1_GPIO_PIN,
.is_inverted = 1
.is_inverted = 0

This comment has been minimized.

Copy link
@avtolstoy

avtolstoy Jan 16, 2019

Member

Will this break non-SoM devices? Should there be a conditional instead here?

This comment has been minimized.

Copy link
@XuGuohui

XuGuohui Jan 24, 2019

Author Contributor

This will also work for the mesh dev kits, since it was the bug in mesh-develop.

en2 = new WizNetif(HAL_SPI_INTERFACE1, D5, D3, D4, mac);
#else // Xenon SoM
en2 = new WizNetif(HAL_SPI_INTERFACE1, D8, 0xFF, D22, mac);

This comment has been minimized.

Copy link
@avtolstoy

avtolstoy Jan 16, 2019

Member

Same here.

@XuGuohui XuGuohui force-pushed the feature/mesh_som branch from 916c124 to 7372aab Feb 18, 2019

@XuGuohui XuGuohui force-pushed the feature/mesh_som branch from 7372aab to 617d754 Feb 27, 2019

@avtolstoy avtolstoy changed the base branch from mesh-develop to develop Mar 5, 2019

@XuGuohui XuGuohui force-pushed the feature/mesh_som branch from 617d754 to 3150f99 Mar 5, 2019

@avtolstoy avtolstoy self-requested a review Mar 5, 2019

@avtolstoy avtolstoy merged commit e7a513b into develop Mar 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the feature/mesh_som branch Mar 5, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Mar 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.