Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release scripts #1687

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@zfields
Copy link
Contributor

commented Jan 31, 2019

Add comments to release.sh
refactor bootloader build section in release.sh
remove release-all.sh in favor of new make_release.sh

Refactor release scripts
Add comments to release.sh, refactor bootloader build in release.sh, remove release-all.sh in favor of new make_release.sh

@zfields zfields requested a review from technobly Jan 31, 2019

@technobly
Copy link
Member

left a comment

I can't remember which came first, but I used to use make_release.sh and then started using release-all.sh probably because it's named release all, but they can do the same thing. 👍 to one less file and the clean up is nice.

@technobly technobly merged commit 0b83dbf into particle-iot:develop Jan 31, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly added this to the 1.0.1-rc.1 milestone Feb 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.