Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Update release.sh parameter handling #1690

Merged
merged 11 commits into from Feb 26, 2019

Conversation

@zfields
Copy link
Contributor

commented Feb 4, 2019

Now uses getopt to parse named parameters
Allows for specification of the output files
Restructures the output folder hierarchy
Tweek filenames to adhere to semantic versioning
Add --debug flag to generate debug builds


  • [Internal] Update release.sh parameter handling #1690

@zfields zfields requested a review from technobly Feb 4, 2019

@zfields zfields added the do not merge label Feb 4, 2019

@zfields zfields force-pushed the zfields:release branch from 28ff49f to 08bbe20 Feb 4, 2019

@zfields zfields removed the do not merge label Feb 14, 2019

@zfields zfields force-pushed the zfields:release branch 2 times, most recently from d10e69d to 22ef61f Feb 14, 2019

@technobly
Copy link
Member

left a comment

Looks like the build still works! :)

Some things I'd like to see changed though:

  • Adding the + before build metadata is a Semver suggestion, but in this case our platform names are not metadata, but more so a part of the version of that built binary. Therefor I would like to see the + changed back to -
  • After un GZ and un TAR the tar.gz instead of particle-1.0.2-electron\ I would like to see 1.0.2\<platform>\.

@zfields zfields force-pushed the zfields:release branch 4 times, most recently from 7ede10e to e98de39 Feb 21, 2019

@zfields zfields requested review from technobly and m-mcgowan Feb 23, 2019

zfields added 9 commits Feb 2, 2019
Update release.sh parameter handling
Now uses `getopt` to parse named parameters
Allows for specification of the output files
Restructures the output folder hierarchy
Tweek filenames to adhere to semantic versioning
Extract publish from release.sh
Adds --debug flag to release.sh to generate debug builds
Add script to generate test binaries
Also adds parameter file for test compile options

@zfields zfields force-pushed the zfields:release branch 3 times, most recently from 1cc2a85 to 46af7a9 Feb 25, 2019

@zfields zfields force-pushed the zfields:release branch 3 times, most recently from adbb231 to 36773bd Feb 26, 2019

Refactor make_release.sh
Now invoke new release scripts

@zfields zfields force-pushed the zfields:release branch from 36773bd to 21fb7bf Feb 26, 2019

@technobly
Copy link
Member

left a comment

Looks good! Just for some metrics:
(28 mins) ./make_release.sh --platform=all --tests --debug --publish=1.0.1
(16 mins) ./make_release.sh --platform=all --tests --publish=1.0.1
(10 mins) ./make_release.sh --platform=all --publish=1.0.1

@zfields zfields merged commit 8075d2d into particle-iot:develop Feb 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly changed the title Update release.sh parameter handling [Internal] Update release.sh parameter handling Feb 26, 2019

@technobly technobly added the internal label Feb 26, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.