Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/gen3 spi ss pin occupied #1696

Merged
merged 2 commits into from Mar 6, 2019

Conversation

@YutingYou
Copy link
Contributor

commented Feb 18, 2019

Problem

Pin A5 stays high when using Ethernet feather wing on Xenon.

ISSUE LINK:
https://community.particle.io/t/pin-a5-stays-high-when-using-ethernet-feather-wing-on-xenon/47646

Solution

Ethernet driver wants to control the SPI SS pin itself, it passes 0xffff to SPI driver, but 0xffff means SPI_DEFAULT_SS, here we use PIN_INVALID(0xff).

Steps to Test

  1. Connect a LED to A5 pin
  2. Flash the example app
  3. Regular blink should be observed

Example App

void setup() {
    pinMode(A5, OUTPUT);
}

void loop() {
    delay(100);
    digitalWrite(A5, HIGH);
    delay(100);
    digitalWrite(A5, LOW);
}

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Mesh] Fixes A5 staying high when using Ethernet feather wing #1696

@YutingYou YutingYou requested a review from avtolstoy Feb 18, 2019

@YutingYou YutingYou force-pushed the fix/gen3-spi-ss-pin-occupied branch from ccef586 to 9a792a4 Mar 5, 2019

@avtolstoy avtolstoy changed the base branch from mesh-develop to develop Mar 5, 2019

@avtolstoy avtolstoy force-pushed the fix/gen3-spi-ss-pin-occupied branch from 9a792a4 to 95038d2 Mar 6, 2019

@avtolstoy avtolstoy merged commit 29f63f7 into develop Mar 6, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/gen3-spi-ss-pin-occupied branch Mar 6, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.