Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Adds missing Device OS release tests #1698

Merged
merged 3 commits into from Feb 25, 2019

Conversation

@technobly
Copy link
Member

commented Feb 25, 2019

Problem

Some Device OS release tests are missing from the repo

Solution

Add missing tests that are only on Brett's machine :)

  • adds upgrade-downgrade, country-updown scripts and updates tests README.md
  • cleanup p1sflashtest script, add exit codes
  • adds SPI Master / Slave (ALT) test

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • N/A - Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Internal] Adds missing Device OS release tests #1698

@technobly technobly added the internal label Feb 25, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Feb 25, 2019

@technobly technobly requested review from JamesHagerman and zfields Feb 25, 2019

@zfields

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

Knee jerk observation: You have added Mac specific scripts. Can they be ported to linux? As far as I know, all our testing equipment (James' shelf of wonderment) is linux based.

@technobly technobly merged commit 1c5fb69 into develop Feb 25, 2019

@technobly technobly deleted the feature/add-release-tests branch Feb 25, 2019

@JamesHagerman

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Thanks for getting this in! As these are moved into the automated testing pipeline, I'll port over whatever fails. The platform specific implementation changes won't be as straight forward as Mac -> Linux because of the containerization and because of the move towards particle-usb/USB Control Requests.

@technobly technobly removed the request for review from JamesHagerman Feb 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.