Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] Fix `brew install gcc-arm-none-eabi-53` formula #1708

Merged
merged 1 commit into from Mar 7, 2019

Conversation

@aroller
Copy link
Contributor

commented Mar 2, 2019

Problem

On MacOS High Sierra 10.13.3:

running the brew install gcc-arm-none-eabi-53 step fails:

Error: gcc-arm-none-eabi-53: /usr/local/Homebrew/Library/Taps/px4/homebrew-px4/gcc-arm-none-eabi-53.rb:13: syntax error, unexpected keyword_end

Adding quotes on line 13 around the prefix command fixes the problem. they need to be escaped in the echo command.

Running again we see the following problem:

undefined local variable or method `gcc' for Formulary::FormulaNamespace400315692c1c92e387b328263702f935:Module

removing gcc-arm-none-eabi-53.rb from the first line of the ruby file allows for successful installation.

Solution

copy and paste of the new text allows brew install to succeed without errors:

brew install gcc-arm-none-eabi-53
==> Installing gcc-arm-none-eabi-53 from px4/px4
Warning: A newer Command Line Tools release is available.
Update them from Software Update in the App Store.

==> Downloading https://launchpad.net/gcc-arm-embedded/5.0/5-2016-q1-update/+download/gcc-arm-none-eabi-5_3-2016q1-20160330-mac.tar.bz2
==> Downloading from https://launchpadlibrarian.net/251687676/gcc-arm-none-eabi-5_3-2016q1-20160330-mac.tar.bz2
######################################################################## 100.0%
==> Copying binaries...
==> cp -rv arm-none-eabi bin lib share /usr/local/Cellar/gcc-arm-none-eabi-53/20160307/
馃嵑  /usr/local/Cellar/gcc-arm-none-eabi-53/20160307: 5,496 files, 443.7MB, built in 2 minutes 46 seconds

Steps to Test

Run the steps in the document.

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Internal] [docs] Fix brew install gcc-arm-none-eabi-53 formula #1708
removed filename header since that is not allowed. escaped quotes on 鈥
鈥ystem cp line since they were being removed.

@avtolstoy avtolstoy requested a review from technobly Mar 4, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Mar 4, 2019

@technobly
Copy link
Member

left a comment

Thank you for the fix @aroller! Sorry it didn't just work like it should have.

@technobly technobly changed the title Requirements Docs: Running brew install gcc-arm-none-eabi-53 fails due to invalid ruby syntax [Internal] Requirements Docs: Running brew install gcc-arm-none-eabi-53 fails due to invalid ruby syntax Mar 4, 2019

@technobly technobly added the internal label Mar 4, 2019

@technobly technobly changed the title [Internal] Requirements Docs: Running brew install gcc-arm-none-eabi-53 fails due to invalid ruby syntax [Internal] Fix `brew install gcc-arm-none-eabi-53` formula Mar 4, 2019

@technobly technobly merged commit 6bb84d1 into particle-iot:develop Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.