Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] system: disable logs #1713

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@avtolstoy
Copy link
Member

commented Mar 6, 2019

Problem

wiring/networking test fails to build on Core due to overflowing flash.

Solution

For now simply disable logging in system to save on flash space.

Steps to Test

Build wiring/networking for Core. It should build.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Bugfix] [Core] Disable system logs for Core to reduce flash space needed to build tests #1713

@avtolstoy avtolstoy requested a review from zfields Mar 6, 2019

@zfields
zfields approved these changes Mar 6, 2019

@avtolstoy avtolstoy merged commit b838ad5 into develop Mar 6, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@avtolstoy avtolstoy deleted the fix/workaround-core-build-size branch Mar 6, 2019

@technobly technobly added this to the 1.0.2-rc.1 milestone Mar 7, 2019

@technobly technobly added the bug label Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.