Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tinker update #1717

Merged
merged 6 commits into from Mar 13, 2019

Conversation

@avtolstoy
Copy link
Member

commented Mar 7, 2019

Problem

Tinker is broken for Gen 2 platforms.

Solution

This PR updates tinker with correct pin mappings for Gen 2 platforms, Gen 3 and Gen 3 SoMs.

This PR also changes the default app built when no APP= is specified to blank.

Steps to Test

Build tinker app, it should work for all the platforms.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Enhancement] Updates Tinker for all platforms #1717

@avtolstoy avtolstoy added this to the 1.0.2-rc.1 milestone Mar 7, 2019

@avtolstoy avtolstoy requested a review from technobly Mar 7, 2019

@avtolstoy avtolstoy force-pushed the feature/tinker-gen2-gen3 branch from c8640ac to 9dc9db9 Mar 8, 2019

@technobly

This comment has been minimized.

Copy link
Member

commented Mar 8, 2019

We need to bump to v6 as well in system_module_version.mk

# Bump by 1 if Tinker has been updated
USER_PART_MODULE_VERSION ?= 6

@avtolstoy avtolstoy requested review from technobly and sergeuz and removed request for technobly Mar 12, 2019

@technobly
Copy link
Member

left a comment

We use tinker-usb-debugging-0.6.0-electron.bin in the CLI. I tried compiling on 0.6.0 and it looks like we'll need to add this:

#ifndef PIN_INVALID
#define PIN_INVALID 0xff
#endif

Other than that it looks great.

@avtolstoy avtolstoy requested a review from technobly Mar 13, 2019

@avtolstoy avtolstoy force-pushed the feature/tinker-gen2-gen3 branch from 035ed47 to 85f226f Mar 13, 2019

@avtolstoy avtolstoy force-pushed the feature/tinker-gen2-gen3 branch from 85f226f to fef8ced Mar 13, 2019

@avtolstoy avtolstoy merged commit 4fe401e into develop Mar 13, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@avtolstoy avtolstoy deleted the feature/tinker-gen2-gen3 branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.