Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen 3] Fix/wiring tests #1719

Merged
merged 20 commits into from Apr 11, 2019

Conversation

@technobly
Copy link
Member

commented Mar 11, 2019

Problem

Many tests needed updates and reliability fixes

Solution

  • [gen 3] increases pwr thread stack size to prevent SOS 10 on boron-som
  • [test] fixes TEST=wiring/no_fixture_long_running PWM test
    Test was broken due to a bad ABS macro that was spitting out mostly negative values, also refactored to iterate from 20-90% Duty Cycle PWM in 5% steps, and made adjustments to keep it from hanging (20-30us pulses still too low to measure on Gen 3), and lightened the rigid accuracy calculations Pulse width should be within 15% error margin resolution > 6, else 40% and finally we don’t bother to test 2 and 3 bit PWM anymore since it’s very crude.
  • [test] move TEST=wiring/no_fixture cellular Band Select tests to a dedicated test app
  • [test] update upgrade-downgrade.sh to 1.1.0-rc.1
  • [test] update country-updown.sh to 1.1.0-rc.1
  • [ci] skip gen 3 modular debug builds
  • [gen 3][test] fixes TEST=wiring/api
  • Revert "travis: disabling tests and DEBUG_BUILD=y for now"
  • [wiring] pmic: avoid calling Wire.begin() if it's already been initialized
  • [system] power: do not report battery soc when there is no battery present or its state is unknown
  • [wiring] network: Network.resolve() for platforms not-supporting getaddrinfo() (Gen 2)
  • [wiring] network: pass hints with protocol = AF_UNSPEC and AI_ADDRCONFIG flag to getaddrinfo
  • [system] network: some fixes in network_ready()
  • [wiring] ipaddress: fixes an annoying pragma message on Gen 2 platforms by basing Wiring_IPv6 on HAL_PLATFORM_IPV6 instead of HAL_IPv6
  • [wiring] network: fixes Network.resolve() to not return IPv4/IPv6 addresses when there is no IPv4/IPv6 connectivity respectively
  • [system] network: extends network_ready() on gen 3 platforms to query for IPv4 or IPv6 connectivity specifically
  • [test] fixes TEST=wiring/networking and adds smaller version TEST=app/networking for Core
  • [test] adds Gen 3 support to SPI tests
  • [Gen 3][SoM][test] no_fixture: adds more dummy reads after PWM period updates
  • Fixes tolerance of DELAY01 test for Gen 3

Steps to Test

Run all tests!


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • (N/A) Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [internal] [Gen 3] Fix/wiring tests #1719

@technobly technobly added this to the 1.1.0-rc.1 milestone Mar 11, 2019

@technobly technobly force-pushed the fix/wiring-tests branch from 51d04ac to bb09f69 Mar 11, 2019

@avtolstoy

This comment has been minimized.

Copy link
Member

commented Mar 12, 2019

PWM tests are still broken and are to be fixed separately in #1590

@technobly technobly force-pushed the fix/wiring-tests branch from 8408911 to 8ca5583 Mar 15, 2019

@technobly technobly force-pushed the fix/wiring-tests branch 2 times, most recently from a8c7d82 to b1155dc Mar 27, 2019

@avtolstoy avtolstoy force-pushed the fix/wiring-tests branch from 5b367f3 to 8a38244 Mar 28, 2019

@technobly technobly force-pushed the fix/wiring-tests branch 3 times, most recently from dab3e7b to 53673c1 Apr 2, 2019

technobly and others added 17 commits Mar 11, 2019
[wiring] network: fixes Network.resolve() to not return IPv4/IPv6 add…
…resses when there is no IPv4/IPv6 connectivity respectively
[wiring] ipaddress: fixes an annoying pragma message on Gen 2 platfor…
…ms by basing Wiring_IPv6 on HAL_PLATFORM_IPV6 instead of HAL_IPv6
technobly added 3 commits Apr 5, 2019
[test] fixes TEST=wiring/no_fixture_long_running PWM test
Test was broken due to a bad ABS macro that was spitting out mostly negative values, also refactored to iterate from 20-90% Duty Cycle PWM in 5% steps, and made adjustments to keep it from hanging (20-30us pulses still too low to measure on Gen 3), and lightened the rigid accuracy calculations `Pulse width should be within 15% error margin resolution > 6, else 40%` and finally we don’t bother to test 2 and 3 bit PWM anymore since it’s very crude.

@technobly technobly force-pushed the fix/wiring-tests branch from d568927 to 7cf10ff Apr 11, 2019

@technobly technobly requested a review from m-mcgowan Apr 11, 2019

@technobly technobly changed the title [Gen 3] Fix/wiring tests [WIP] [Gen 3] Fix/wiring tests Apr 11, 2019

@elijthomas
Copy link

left a comment

Tested by Brett 👍

@technobly technobly merged commit e8aad04 into develop Apr 11, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@technobly technobly deleted the fix/wiring-tests branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.