Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] [G350] fixes Cellular.RSSI() issues due to unknown RAT #1721

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@technobly
Copy link
Member

commented Mar 13, 2019

Problem

Cellular.RSSI() does not work on Electron G350 due to RAT (Radio Access Technology) being unknown, and subsequently conversion of values errors out. This affects the Cellular.RSSI() API and also Device Diagnostics.

Solution

During registration, default to RAT = ACT_GSM if device is Electron G350.

Steps to Test

  • Observe with v1.0.0 or v1.0.1 firmware and Tinker, Device Diagnostics contains no device.network.signal.strength: info.
  • Compile with this PR and everything works as expected, assuming the device really has a signal.

References

Examples of the issue here:
https://community.particle.io/t/no-signal-strength-information-for-electron-2g-on-device-os-1-0-0/47460/10?u=bdub


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • (N/A) Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Bugfix] [Electron] [G350] fixes Cellular.RSSI() issues due to unknown RAT #1721

@technobly technobly added this to the 1.1.0-rc.1 milestone Mar 13, 2019

@technobly technobly requested a review from avtolstoy Mar 13, 2019

@technobly technobly force-pushed the fix/electron-rssi branch from 84a89d1 to 43db863 Mar 13, 2019

@technobly technobly requested a review from avtolstoy Mar 13, 2019

@technobly technobly force-pushed the fix/electron-rssi branch from 43db863 to 13ff1a3 Mar 13, 2019

@technobly technobly force-pushed the fix/electron-rssi branch from 13ff1a3 to 313baeb Mar 13, 2019

@technobly technobly merged commit bd9746e into develop Mar 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/electron-rssi branch Mar 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.