Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter check for SPI slave mode with HAL_SPI_INTERFACE1 #1731

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@YutingYou
Copy link
Contributor

commented Mar 18, 2019

Problem

We use high-speed SPI as default SPI, however, it doesn't support SPI slave. This PR adds a parameter check in case users use the wrong mode and cause a failure.


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Enhancement] [Gen 3] Parameter check for SPI slave mode with HAL_SPI_INTERFACE1 #1731

@YutingYou YutingYou requested a review from avtolstoy Mar 18, 2019

@avtolstoy avtolstoy added this to the 1.1.0-rc.1 milestone Mar 18, 2019

@technobly technobly force-pushed the fix/hal/param-check-for-spi-slave-mode branch from a6c399c to 7b8a1d1 Mar 19, 2019

@technobly technobly self-requested a review Mar 19, 2019

@technobly
Copy link
Member

left a comment

Approving again after rebasing...

@technobly technobly merged commit 7fbf145 into develop Mar 19, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/hal/param-check-for-spi-slave-mode branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.