Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] disables shallow submodule checkouts #1735

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@avtolstoy
Copy link
Member

commented Mar 26, 2019

Problem

We've introduced a change to .travis.yml recently to shallowly checkout the submodules with depth=1 to optimize build times, which doesn't really work if the submodule master branch is updated and the reference update is not in develop yet.

Solution

This PR Removes submodule_depth: 1 option from .travis.yml. This does not affect build times that much, they are still at around 15 mins.

Steps to Test

N/A

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [Internal] [ci] disables shallow submodule checkouts #1735

@avtolstoy avtolstoy requested a review from sergeuz Mar 26, 2019

@avtolstoy avtolstoy merged commit 03427ba into develop Mar 26, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/ci-submodule-depth branch Mar 26, 2019

@technobly technobly added this to the 1.1.0-rc.1 milestone Apr 2, 2019

@technobly technobly added the internal label Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.