Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bootloader] SysTick needs to be disabled in Reset_System() on Gen 2 platforms #1741

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@avtolstoy
Copy link
Member

commented Apr 2, 2019

Problem

Bootloader on Gen 2 platforms built out of develop currently fails to boot correctly into system parts. This is an artifact of Gen2/3 merge, where the preparatory logic for deinitializing things in the bootloader before jumping into the application was moved out of the common bootloader code into platform-specific Reset_System() function.

Solution

Disable SysTick in Reset_System() on Gen 2 platforms and core.

Steps to Test

Build bootloader out of this branch, flash it, it should correctly jump into system parts.

Example App

N/A

References

N/A


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [bootloader] SysTick needs to be disabled in Reset_System() on Gen 2 platforms #1741

@avtolstoy avtolstoy added this to the 1.1.0-rc.1 milestone Apr 2, 2019

@avtolstoy avtolstoy requested review from sergeuz and technobly Apr 2, 2019

@avtolstoy avtolstoy force-pushed the fix/gen2-bootloader-reset-system branch from f3d6cf0 to 3337ffb Apr 2, 2019

@sergeuz
sergeuz approved these changes Apr 2, 2019

@sergeuz sergeuz added ready to merge and removed needs review labels Apr 2, 2019

@avtolstoy avtolstoy removed the request for review from technobly Apr 2, 2019

@avtolstoy avtolstoy merged commit 235749e into develop Apr 2, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@avtolstoy avtolstoy deleted the fix/gen2-bootloader-reset-system branch Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.