Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail the build if PARTICLE_DEVELOP is not defined #1750

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@sergeuz
Copy link
Member

commented Apr 16, 2019

The PARTICLE_DEVELOP check still generates a lot of noise during compilation: https://community.particle.io/t/issue-fatal-not-a-git-repository-or-any-of-the-parent-directories-git/48744.

After a discussion with @monkbroc we decided to remove that check entirely.


  • [internal] Do not fail the build if PARTICLE_DEVELOP is not defined #1750

@sergeuz sergeuz added the internal label Apr 16, 2019

@sergeuz sergeuz requested a review from monkbroc Apr 16, 2019

@monkbroc
Copy link
Member

left a comment

👍 People that clone the Device OS repo, compile it locally and flash it to their device already know that they are working with unreleased code. The additional message is unnecessary and the check fails noisily when the directory is not a git repository.

@sergeuz sergeuz force-pushed the fix/develop_check branch from b335fb6 to c84a1c6 Apr 16, 2019

@monkbroc
Copy link
Member

left a comment

:shipit:

@avtolstoy avtolstoy force-pushed the fix/develop_check branch from c84a1c6 to af65bbc Apr 23, 2019

@avtolstoy avtolstoy self-requested a review Apr 23, 2019

@avtolstoy avtolstoy merged commit 43c08ed into develop Apr 23, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/develop_check branch Apr 23, 2019

@technobly technobly modified the milestones: 1.2.0-beta.1, 1.1.0-rc.2 Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.