Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the message "External flash is not supported" from Gen 3 builds #1751

Merged
merged 1 commit into from Apr 22, 2019

Conversation

@monkbroc
Copy link
Member

commented Apr 19, 2019

Problem

device-os/modules$ make PLATFORM=argon -s
  /home/monkbroc/Programming/firmware/modules/argon/system-part1/makefile /home/monkbroc/Programming/firmware/modules/argon/user-part/makefile
src/control/storage.cpp:63:50: note: #pragma message: External flash is not supported
 #pragma message("External flash is not supported")
                                                  ^
   text	   data	    bss	    dec	    hex	filename
 649424	   2156	  65792	 717372	  af23c	../../../build/target/system-part1/platform-12-m/system-part1.elf
Creating ../../../build/target/user-part/platform-12-m/module_user_memory.ld ...
Creating ../../../build/target/user-part/platform-12-m/module_user_memory.ld ...
   text	   data	    bss	    dec	    hex	filename
   4764	    104	    780	   5648	   1610	../../../build/target/user-part/platform-12-m/user-part.elf

This message shows up in all Gen 3 Device OS builds, including quiet builds. It is not an actionable message for end users. If we need to implement additional support for external flash in Device OS, let's plan for that instead of showing a message in the build output.

Solution

Remove the message


  • [internal] Remove the message "External flash is not supported" from Gen 3 builds #1751
Remove the message "External flash is not supported" from Gen 3 builds
This message shows up in all Gen 3 Device OS builds. It is not an actionable message for end users. If we need to implement additional support for external flash in Device OS, let's plan for that instead of showing a TODO message in the build output.

@monkbroc monkbroc requested a review from avtolstoy Apr 19, 2019

@avtolstoy avtolstoy added this to the 1.2.0-rc.1 milestone Apr 22, 2019

@avtolstoy avtolstoy merged commit 82634d8 into develop Apr 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the feature/external-flash-message branch Apr 22, 2019

@avtolstoy avtolstoy modified the milestones: 1.2.0-rc.1, 1.2.0-beta.1 Apr 23, 2019

@technobly technobly added internal and removed enhancement labels Apr 26, 2019

@technobly technobly modified the milestones: 1.2.0-beta.1, 1.1.0-rc.2 Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.