Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesh network scan fixes #1760

Merged
merged 4 commits into from May 16, 2019

Conversation

@sergeuz
Copy link
Member

commented Apr 30, 2019

Problem

This PR introduces the following changes:

  • Make the duration of an active scan configurable.
  • Remove duplicate network entries from the network scan results.
  • Remove our workarounds for OpenThread bugs that were fixed in the upstream repo and pulled into our dependency branch (see openthread/openthread#3246).

Steps to Test

  • Set up a mesh network with at least 2 nodes (more is better).
  • Perform a few network scans using the CLI and a device which is not a member of the same network:
particle mesh scan my_device
  • Make sure there are no duplicate network entries in the scan results.

References

  • [ch31161]

  • [bugfix] [gen 3] Mesh network scan fixes #1760
  • [enhancement] [gen 3] Mesh network scan enhancements #1760

@sergeuz sergeuz requested a review from avtolstoy Apr 30, 2019

@sergeuz sergeuz referenced this pull request May 6, 2019

@sergeuz sergeuz added this to the 1.2.0-rc.1 milestone May 15, 2019

@sergeuz sergeuz force-pushed the fix/mesh_scan branch from 9e1429a to e9afa37 May 16, 2019

@sergeuz sergeuz merged commit 912bb22 into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@sergeuz sergeuz deleted the fix/mesh_scan branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.