Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch32350/error codes - Create AT specific errors #1766

Merged
merged 1 commit into from May 7, 2019

Conversation

@zfields
Copy link
Contributor

commented May 6, 2019

Update SYSTEM_ERROR_UNKNOWN to SYSTEM_ERROR_AT_NOT_OK and SYSTEM_ERROR_AT_RESPONSE_UNEXPECTED to provide context to error messages for the sake of debugging.

ch32350 - Update error codes in Gen3 parser to facilitate debugging efforts and provide context to system errors


  • [enhancement] [gen 3] Update error codes in Gen3 parser to facilitate debugging efforts and provide context to system errors #1766

@zfields zfields requested review from avtolstoy and sergeuz May 6, 2019

@zfields zfields force-pushed the ch32350/error-codes branch 2 times, most recently from ad397b1 to 18a4031 May 6, 2019

Create AT specific errors
Update SYSTEM_ERROR_UNKNOWN to SYSTEM_ERROR_AT_NOT_OK and SYSTEM_ERROR_AT_RESPONSE_UNEXPECTED to provide context to error messages for the sake of debugging.

ch32350 - Update error codes in Gen3 parser to facilitate debugging efforts and provide context to system errors

@zfields zfields force-pushed the ch32350/error-codes branch from 18a4031 to fdcc161 May 7, 2019

@sergeuz
sergeuz approved these changes May 7, 2019

@zfields zfields merged commit cd785fa into release/v1.2.0 May 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zfields zfields deleted the ch32350/error-codes branch May 7, 2019

@technobly technobly added this to the 1.2.0-rc.1 milestone May 15, 2019

@technobly technobly removed the request for review from avtolstoy May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.