Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Spark Core function calls broken in 0.8.0-rc.4 [ch32050] #1770

Merged
merged 2 commits into from May 16, 2019

Conversation

@technobly
Copy link
Member

commented May 10, 2019

Problem

Spark Core function calls broken in 0.8.0-rc.4 #1537 when updating API limits for Gen 2 devices.

Solution

Fixes the typo in spark_protocol.cpp and adds additional checks against buffer overflow, properly adds 1 extra byte for null termination in various buffers, and updates the TEST=app/cloudtest to ensure these are tested on all future releases.

Steps to Test

Run TEST=app/cloudtest (see it's README.md) for details on setup.

References

#1537
Fixes #1569


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • (N/A) Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] Fixes Spark Core function calls broken in 0.8.0-rc.4 [ch32050] #1770

@technobly technobly added the bug label May 10, 2019

@technobly technobly added this to the 1.2.0-rc.1 milestone May 10, 2019

@technobly technobly requested a review from m-mcgowan May 10, 2019

@m-mcgowan
Copy link
Contributor

left a comment

Nice cleanup of the code! 💙

@technobly technobly force-pushed the fix/core-function-calls branch from 8777640 to 91ade79 May 16, 2019

@technobly technobly merged commit 6b24894 into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/core-function-calls branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.