Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system] network manager: allows to clear interface-specific credentials notwithstanding interface state, except for Mesh #1773

Merged
merged 1 commit into from May 16, 2019

Conversation

@avtolstoy
Copy link
Member

commented May 13, 2019

Problem

WiFi.clearCredentials() doesn't work unless WiFi.disconnect()/off() are called.

Solution

Allow to clear interface-specific credentials notwithstanding interface state, except for Mesh.

Steps to Test

Run the example app on an Argon with configured WiFi credentials.

  1. D7 should light up and go off in 5 seconds
  2. Argon should still be breathing cyan
  3. Reset it, it should no longer be able to connect to WiFi network

Example App

#include "application.h"

/* executes once at startup */
void setup() {
    pinMode(D7, OUTPUT);
    digitalWrite(D7, LOW);

    digitalWrite(D7, WiFi.clearCredentials() ? HIGH : LOW);
    delay(5000);
    digitalWrite(D7, WiFi.hasCredentials() ? LOW : HIGH);
}

/* executes continuously after setup() runs */
void loop() {

}

References

  • [CH30587]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [system] network manager: allows to clear interface-specific credentials notwithstanding interface state, except for Mesh #1773

@avtolstoy avtolstoy added this to the 1.2.0-rc.1 milestone May 13, 2019

@avtolstoy avtolstoy requested a review from sergeuz May 13, 2019

@sergeuz sergeuz added ready to merge and removed needs review labels May 15, 2019

[system] network manager: allows to clear interface-specific credenti…
…als notwithstanding its state, except for Mesh

@avtolstoy avtolstoy force-pushed the fix/argon-wifi-clear-credentials-ch30587 branch from 8cf14d2 to 5e9159e May 16, 2019

@avtolstoy avtolstoy merged commit 9048cf4 into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/argon-wifi-clear-credentials-ch30587 branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.