Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron/LTE] Make sure that the RAT information is actual before calculating signal strength (RSSI) and quality #1779

Merged
merged 4 commits into from May 16, 2019

Conversation

@avtolstoy
Copy link
Member

commented May 15, 2019

Problem

Invalid RAT information causes signal strength/quality information to be unavailable. This is caused by AT+COPS? in checkNetStatus() which invalidates the RAT set by URC handlers as it only handles GSM and UTRAN for some reason: https://github.com/particle-iot/device-os/blob/develop/hal/src/electron/modem/mdm_hal.cpp#L1380

Solution

  1. Fix AT+COPS? handler to correctly parse all RATs
  2. Adds explicit AT+COPS? call to getSignalStrength()

Steps to Test

N/A

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bugfix] [Electron/LTE] Make sure that the RAT information is actual before calculating signal strength (RSSI) and quality #1779

@avtolstoy avtolstoy added this to the 1.2.0-rc.1 milestone May 15, 2019

@avtolstoy avtolstoy requested review from technobly and zfields May 15, 2019

hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved

@zfields zfields force-pushed the ch29061/cellular-vitals branch from 24e00c3 to 870b1b4 May 15, 2019

@technobly
Copy link
Member

left a comment

Just this one change, everything else looks good to me as is.

hal/src/electron/modem/mdm_hal.cpp Outdated Show resolved Hide resolved
@zfields

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

I rebased on the new v1.2.0. I didn't realize you were merging into my branch.

You will need to rebase on me again.

@zfields zfields force-pushed the ch29061/cellular-vitals branch 2 times, most recently from b88fbfd to 45fbd6b May 16, 2019

@avtolstoy avtolstoy force-pushed the ch32382/gen2-rat branch from bc18768 to 329bd6d May 16, 2019

@avtolstoy avtolstoy requested review from technobly and zfields May 16, 2019

@avtolstoy avtolstoy removed the do not merge label May 16, 2019

@zfields zfields force-pushed the ch29061/cellular-vitals branch from 45fbd6b to 709a818 May 16, 2019

@technobly technobly changed the base branch from ch29061/cellular-vitals to develop May 16, 2019

@technobly technobly changed the title [Electron] Make sure that the RAT information is actual before calculating signal strength and quality [Electron/LTE] Make sure that the RAT information is actual before calculating signal strength (RSSI) and quality May 16, 2019

@technobly technobly force-pushed the ch32382/gen2-rat branch from c0de81b to a44aa31 May 16, 2019

@technobly technobly merged commit 49de7ad into develop May 16, 2019

1 check passed

continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the ch32382/gen2-rat branch May 16, 2019

@technobly technobly referenced this pull request Jul 2, 2019
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.